jackye1995 commented on pull request #1767: URL: https://github.com/apache/iceberg/pull/1767#issuecomment-730567389
The ACL support #1788 should not be a big issue, it is only a single additional method call `acl(...)` and only affects `PutObjectRequest` and `CreateMultipartUploadRequest`. I was thinking there is still a way to use reflection, using a similar logic as #1786 . We need to check if the method exists or not when setting the value. The biggest concern I have with reflection is that I don't know how much it affects the performance since it is in the critical path for upload. Let me run some tests and come back with some data for that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
