alexandre-normand commented on code in PR #717:
URL: https://github.com/apache/iceberg-go/pull/717#discussion_r2776252084
##########
table/transaction.go:
##########
@@ -653,21 +692,19 @@ func (t *Transaction)
classifyFilesForFilteredOverwrite(ctx context.Context, fs
}
spec := meta.PartitionSpec()
if !spec.IsUnpartitioned() {
- manifestEval, err = newManifestEvaluator(spec, schema, filter,
true)
+ manifestEval, err = newManifestEvaluator(spec, schema, filter,
caseSensitive)
if err != nil {
return nil, nil, fmt.Errorf("failed to create manifest
evaluator: %w", err)
}
}
s := t.meta.currentSnapshot()
- manifests, err := s.Manifests(fs)
- if err != nil {
- return nil, nil, fmt.Errorf("failed to get manifests: %w", err)
- }
-
- type classifiedFiles struct {
- toDelete []iceberg.DataFile
- toRewrite []iceberg.DataFile
+ var manifests []iceberg.ManifestFile
+ if s != nil {
+ manifests, err = s.Manifests(fs)
+ if err != nil {
+ return nil, nil, fmt.Errorf("failed to get manifests:
%w", err)
+ }
}
Review Comment:
This struct type was unused so I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
