SYaoJun commented on PR #555: URL: https://github.com/apache/iceberg-cpp/pull/555#issuecomment-3869010367
> I approve the part of `std::move` and oppose the part of adding `typename`. If there is a clang-tidy warning, we can hide it in `.clang-tidy`. Thanks for your time—I've updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
