rymurr commented on a change in pull request #1587: URL: https://github.com/apache/iceberg/pull/1587#discussion_r527697410
########## File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java ########## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.nessie; + +import com.dremio.nessie.api.TreeApi; +import com.dremio.nessie.client.NessieClient; +import com.dremio.nessie.error.NessieConflictException; +import com.dremio.nessie.error.NessieNotFoundException; +import com.dremio.nessie.model.Contents; +import com.dremio.nessie.model.IcebergTable; +import com.dremio.nessie.model.ImmutableDelete; +import com.dremio.nessie.model.ImmutableOperations; +import com.dremio.nessie.model.ImmutablePut; +import com.dremio.nessie.model.Operations; +import com.dremio.nessie.model.Reference; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import org.apache.hadoop.conf.Configurable; +import org.apache.hadoop.conf.Configuration; +import org.apache.iceberg.BaseMetastoreCatalog; +import org.apache.iceberg.CatalogProperties; +import org.apache.iceberg.CatalogUtil; +import org.apache.iceberg.TableOperations; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.SupportsNamespaces; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.AlreadyExistsException; +import org.apache.iceberg.exceptions.CommitFailedException; +import org.apache.iceberg.exceptions.NamespaceNotEmptyException; +import org.apache.iceberg.exceptions.NoSuchNamespaceException; +import org.apache.iceberg.exceptions.NoSuchTableException; +import org.apache.iceberg.hadoop.HadoopFileIO; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.base.Joiner; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Nessie implementation of Iceberg Catalog. + * + * <p> + * A note on namespaces: Nessie namespaces are implicit and do not need to be explicitly created or deleted. + * The create and delete namespace methods are no-ops for the NessieCatalog. One can still list namespaces that have + * objects stored in them to assist with namespace-centric catalog exploration. + * </p> + */ +public class NessieCatalog extends BaseMetastoreCatalog implements AutoCloseable, SupportsNamespaces, Configurable { + private static final Logger logger = LoggerFactory.getLogger(NessieCatalog.class); + private static final Joiner SLASH = Joiner.on("/"); + public static final String NESSIE_WAREHOUSE_DIR = "nessie.warehouse.dir"; + private NessieClient client; + private String warehouseLocation; + private Configuration config; + private UpdateableReference reference; + private String name; + private FileIO fileIO; + + public NessieCatalog() { + } + + @Override + public void initialize(String inputName, Map<String, String> options) { + String fileIOImpl = options.get(CatalogProperties.FILE_IO_IMPL); + this.fileIO = fileIOImpl == null ? new HadoopFileIO(config) : CatalogUtil.loadFileIO(fileIOImpl, options, config); + this.name = inputName == null ? "nessie" : inputName; + this.client = NessieClient.withConfig(options::get); + + this.warehouseLocation = options.get(NESSIE_WAREHOUSE_DIR); + if (warehouseLocation == null) { + throw new IllegalStateException("Parameter nessie.warehouse.dir not set, nessie can't store data."); + } + final String requestedRef = options.get(NessieClient.CONF_NESSIE_REF); + this.reference = loadReference(requestedRef); + } + + @Override + public void close() { + client.close(); + } + + @Override + public String name() { + return name; + } + + @Override + protected TableOperations newTableOps(TableIdentifier tableIdentifier) { + TableReference pti = TableReference.parse(tableIdentifier); + UpdateableReference newReference = this.reference; + if (pti.getReference() != null) { + newReference = loadReference(pti.getReference()); + } + return new NessieTableOperations(NessieUtil.toKey(pti.getTableIdentifier()), newReference, client, fileIO); + } + + @Override + protected String defaultWarehouseLocation(TableIdentifier table) { + if (table.hasNamespace()) { + return SLASH.join(warehouseLocation, table.namespace().toString(), table.name()); + } + return SLASH.join(warehouseLocation, table.name()); + } + + @Override + public List<TableIdentifier> listTables(Namespace namespace) { + return tableStream(namespace).collect(Collectors.toList()); + } + + @Override + public boolean dropTable(TableIdentifier identifier, boolean purge) { + reference.checkMutable(); + + IcebergTable existingTable = table(identifier); + if (existingTable == null) { + return false; + } + + // We try to drop the table. Simple retry after ref update. + int count = 0; + while (count < 5) { + count++; + try { + dropTableInner(identifier); + break; + } catch (NessieConflictException e) { + // pass for retry + } catch (NessieNotFoundException e) { + logger.error("Cannot drop table: ref is no longer valid.", e); + return false; + } + } + if (count >= 5) { + logger.error("Cannot drop table: failed after retry (update hash and retry)"); + return false; + } + return true; + } + + @Override + public void renameTable(TableIdentifier from, TableIdentifier toOriginal) { + reference.checkMutable(); + + TableIdentifier to = NessieUtil.removeCatalogName(toOriginal, name()); + + IcebergTable existingFromTable = table(from); + if (existingFromTable == null) { + throw new NoSuchTableException("table %s doesn't exists", from.name()); + } + IcebergTable existingToTable = table(to); + if (existingToTable != null) { + throw new AlreadyExistsException("table %s already exists", to.name()); + } + + Operations contents = ImmutableOperations.builder() + .addOperations(ImmutablePut.builder().key(NessieUtil.toKey(to)).contents(existingFromTable).build(), + ImmutableDelete.builder().key(NessieUtil.toKey(from)).build()) + .build(); + + try { + client.getTreeApi().commitMultipleOperations(reference.getAsBranch().getName(), reference.getHash(), + "iceberg rename table", contents); + // TODO: fix this so we don't depend on it in tests. + refresh(); + } catch (NessieConflictException e) { + throw new CommitFailedException(e, "failed"); Review comment: yup. I believe I was lazy here b/c that exception is always swallowed by the re-try logic above. Not such a good excuse :-) fixed now ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
