geruh commented on issue #3029: URL: https://github.com/apache/iceberg-python/issues/3029#issuecomment-3875049137
Thanks for opening this Kevin, I've been thinking about this a bit differently. There are 3 main use cases for the make file, and docker interactions: 1. Developers testing their changes 2. Release Validators (Probably a better name for this, but it sounds like a gladiator) 3. CI Action automated pipeline runs With that in mind, maybe the best path forward is keeping all containers running unless make docker-cleanup (like make clean) is explicitly called. At that point, we clean up all of our defined containers. This avoids the overhead of spinning up/down containers repeatedly while still giving users an explicit cleanup when needed also, it can be added to release verification steps so the validators know everything is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
