lishuxu commented on code in PR #544:
URL: https://github.com/apache/iceberg-cpp/pull/544#discussion_r2786561393
##########
src/iceberg/catalog/rest/rest_catalog.cc:
##########
@@ -172,7 +198,7 @@ Result<std::vector<Namespace>>
RestCatalog::ListNamespaces(const Namespace& ns)
}
ICEBERG_ASSIGN_OR_RAISE(
const auto response,
- client_->Get(path, params, /*headers=*/{},
*NamespaceErrorHandler::Instance()));
+ client_->Get(path, params, *NamespaceErrorHandler::Instance()));
Review Comment:
We don't have a session catalog yet, so there's no session context to derive
a contextual session from. I think using catalog_session_ directly is
equivalent to what Java's RESTCatalog does. Will add contextual session support
when session-aware catalog is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
