singhpk234 commented on code in PR #14621: URL: https://github.com/apache/iceberg/pull/14621#discussion_r2789802262
########## docs/docs/encryption.md: ########## @@ -0,0 +1,153 @@ +--- +title: "Encryption" +--- +<!-- + - Licensed to the Apache Software Foundation (ASF) under one or more + - contributor license agreements. See the NOTICE file distributed with + - this work for additional information regarding copyright ownership. + - The ASF licenses this file to You under the Apache License, Version 2.0 + - (the "License"); you may not use this file except in compliance with + - the License. You may obtain a copy of the License at + - + - http://www.apache.org/licenses/LICENSE-2.0 + - + - Unless required by applicable law or agreed to in writing, software + - distributed under the License is distributed on an "AS IS" BASIS, + - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + - See the License for the specific language governing permissions and + - limitations under the License. + --> + +# Encryption + +Iceberg table encryption protects confidentiality and integrity of table data in an untrusted storage. The `data`, `delete`, `manifest` and `manifest list` files are encrypted and tamper-proofed before being sent to the storage backend. + +The `metadata.json` file does not contain data or stats, and is therefore not encrypted. Review Comment: Thank you for taking look @ggershinsky ! 1. Partition summary or even any summary props are supposed to be optional and not defined in spec, when you use iceberg java impl these are collected when `write.summary.partition-limit` is enable (default off) please check this for details : https://iceberg.apache.org/docs/nightly/configuration/#write-properties 2. Yes they are enabled by the writer (user setting this table prop `write.summary.partition-limit` engines such as spark etc collect these when enabled. 3. please check this https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotSummary.java#L202 on a high level it can reveal which column values and stats on file counts etc https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotSummary.java#L163 please let me know what do you think about it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
