nastra commented on code in PR #14800:
URL: https://github.com/apache/iceberg/pull/14800#discussion_r2792961167
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDeltaEncodedValuesReader.java:
##########
@@ -91,6 +91,11 @@ public void initFromPage(int valueCount,
ByteBufferInputStream in) throws IOExce
firstValue = BytesUtils.readZigZagVarLong(this.inputStream);
}
+ // True value count. May be less than valueCount because of nulls
+ int getTotalValueCount() {
Review Comment:
we don't use `get` prefixes in the codebase, so this should be
`totalValueCount()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
