pvary commented on code in PR #15255:
URL: https://github.com/apache/iceberg/pull/15255#discussion_r2794316284
##########
orc/src/main/java/org/apache/iceberg/orc/ORC.java:
##########
@@ -775,12 +780,20 @@ public ReadBuilder withNameMapping(NameMapping
newNameMapping) {
return this;
}
+ ReadBuilder constantFieldIds(Set<Integer> newConstantFieldIds) {
+ this.constantFieldIds = newConstantFieldIds;
+ return this;
+ }
+
public <D> CloseableIterable<D> build() {
Preconditions.checkNotNull(schema, "Schema is required");
return new OrcIterable<>(
file,
conf,
- schema,
+ // This is a behavioral change. Previously there were an error if
metadata columns were
Review Comment:
This is needed, so ORC handles the partitioned reads the same way as the
other readers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
