aokolnychyi commented on code in PR #15297: URL: https://github.com/apache/iceberg/pull/15297#discussion_r2794454002
########## spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java: ########## @@ -96,10 +95,10 @@ public class SparkScanBuilder private final Table table; private final CaseInsensitiveStringMap options; private final SparkReadConf readConf; - private final List<String> metaColumns = Lists.newArrayList(); + private final Set<String> metaFieldNames = Sets.newLinkedHashSet(); private final InMemoryMetricsReporter metricsReporter; - private Schema schema; + private Schema projection; Review Comment: I am later going to keep the entire `schema` here as well. This is a projection, defaulted to the schema initially. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
