swapna267 commented on code in PR #15279:
URL: https://github.com/apache/iceberg/pull/15279#discussion_r2795420820
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java:
##########
@@ -328,4 +351,94 @@ private String createWarehouse() {
throw new UncheckedIOException(e);
}
}
+
+ @TestTemplate
+ public void testCreateDynamicIcebergSink() throws
DatabaseAlreadyExistException {
Review Comment:
This test in particular is testing the DynamicIcebergSink only by setting
use-dynamic-iceberg-sink to true.
But i also see, TestIcebergConnector is not testing the new IcebergSink code
path. Partially it's covered in TestFlinkTableSink (where iceberg tables are
created in Iceberg catalog).
If my understanding is right, i prefer to put that into separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
