aokolnychyi commented on code in PR #15301:
URL: https://github.com/apache/iceberg/pull/15301#discussion_r2796065323
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewriteBuilder.java:
##########
@@ -82,10 +79,10 @@ public Write build() {
StructLike partition = partition(fileSetId, tasks);
return new SparkPositionDeletesRewrite(
- spark, table, writeConf, writeInfo, writeSchema, dsSchema, specId,
partition);
+ spark, table, fileSetId, writeConf, info, writeSchema, dsSchema,
specId, partition);
}
- private int specId(String fileSetId, List<PositionDeletesScanTask> tasks) {
+ private static int specId(String fileSetId, List<PositionDeletesScanTask>
tasks) {
Review Comment:
Required to avoid checkstyle failures due to name collision (fileSetId).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
