danielcweeks commented on code in PR #15209:
URL: https://github.com/apache/iceberg/pull/15209#discussion_r2796128801
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -107,6 +107,8 @@ public class IcebergSinkConfig extends AbstractConfig {
@VisibleForTesting static final String COMMA_NO_PARENS_REGEX =
",(?![^()]*+\\))";
+ public static final int DEFAULT_VALUE_MIN_FORMAT_VERSION = 3;
Review Comment:
We shouldn't expose this as public, rather just include it where it's
referenced (probably IcebergWriterFactory or SchemaUtils)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
