RussellSpitzer commented on a change in pull request #1796:
URL: https://github.com/apache/iceberg/pull/1796#discussion_r527874919
##########
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##########
@@ -78,6 +81,13 @@ public void accept(String file) {
RemoveSnapshots(TableOperations ops) {
this.ops = ops;
this.base = ops.current();
+
+ ValidationException.check(
+ PropertyUtil.propertyAsBoolean(base.properties(), GC_ENABLED,
GC_ENABLED_DEFAULT),
+ "Not allowed to expire snapshots as the garbage collection is disabled
for this table. " +
+ "Make sure this table is the exclusive owner of its data files before
allowing garbage collection. " +
+ "If the table was created using the SNAPSHOT operation, it is not safe
to expire snapshots in it since " +
+ "this may remove files in the original table.");
Review comment:
I think it's still ok to put in instructions for disabling this
parameter as a workaround. Just helps a user to know how to unblock themselves
just in case. Also nit: "Cannot expire snapshots" would follow our pattern for
errors in other places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
