nastra commented on code in PR #15104:
URL: https://github.com/apache/iceberg/pull/15104#discussion_r2799183048
##########
core/src/main/java/org/apache/iceberg/metrics/InMemoryMetricsReporter.java:
##########
@@ -35,4 +36,13 @@ public ScanReport scanReport() {
"Metrics report is not a scan report");
return (ScanReport) metricsReport;
}
+
+ @Nullable
Review Comment:
@manuzhang I think it's still unclear to me why the logic in `commitReport`
is different from `scanReport`. Why can't we use the exact same logic for both
methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
