danielcweeks commented on PR #15209: URL: https://github.com/apache/iceberg/pull/15209#issuecomment-3893458562
@kumarpritam863 After spending some time looking at what we're doing here, I'm not convinced this is the right way to handle default values in KC. The issue is that we are relying on the first appearance of a value to define the default, which we do not re-check at any point and creates a "dual" source of truth for default values. If the table or the schema registry changes the default value, they would be inconsistent. I feel like we need to figure out a more complimentary way to deal with this. I think it probably makes more sense to adhere to the default value coming from KC and just write the value if the incoming value is null and then fallback to the table's default value if there is no default defined for the column. I'd be interested in @bryanck's thought's on this, but I don't feel comfortable with the way we're assigning defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
