rcjverhoef opened a new pull request, #3042:
URL: https://github.com/apache/iceberg-python/pull/3042

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace 
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   
   # Rationale for this change
   
   Vended credentials don't work with REST catalogs following latests specs. 
Per [latest 
spec](https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L3485):
   
   >  Clients must first check whether the respective credentials exist in the 
`storage-credentials` field before checking the `config` for credentials.
   
   This is missing in pyiceberg. REST catalogs that don't expose a config field 
are hence not compatible.
   
   ## Are these changes tested?
   
   Yes, ran locally against my REST catalog implementation, added tests.
   
   ## Are there any user-facing changes?
   
   No API changes. REST catalogs that return vended credentials via 
storage-credentials will now work correctly.
   
   <!-- In the case of user-facing changes, please add the changelog label. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to