subkanthi commented on code in PR #723:
URL: https://github.com/apache/iceberg-go/pull/723#discussion_r2804786787
##########
table/transaction.go:
##########
@@ -433,6 +433,108 @@ func (t *Transaction) ReplaceDataFiles(ctx
context.Context, filesToDelete, files
return t.apply(updates, reqs)
}
+// AddDataFiles adds pre-built DataFiles to the table without scanning them
from storage.
Review Comment:
https://github.com/apache/iceberg-go/pull/710#discussion_r2771295107 , very
similar to this comment, should we warn the user that the storage doesnt
exist(you could even add a local file path here)
Have a `--force` option, maybe? @zeroshade
Ideally we would want a CLI option too, maybe the validation can be done in
the CLI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
