nastra commented on code in PR #15232:
URL: https://github.com/apache/iceberg/pull/15232#discussion_r2804908229
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -744,9 +736,21 @@ private static String planIDFromPathVars(Map<String,
String> pathVars) {
private static SnapshotMode snapshotModeFromQueryParams(Map<String, String>
queryParams) {
return SnapshotMode.valueOf(
queryParams
- .getOrDefault(
- RESTCatalogProperties.SNAPSHOTS_QUERY_PARAMETER,
- RESTCatalogProperties.SNAPSHOT_LOADING_MODE_DEFAULT)
+ .getOrDefault("snapshots",
RESTCatalogProperties.SNAPSHOT_LOADING_MODE_DEFAULT)
.toUpperCase(Locale.US));
}
+
+ /**
+ * Strips the compression suffix from an ETag value.
+ *
+ * <p>Jetty 12 appends "--gzip" to ETags when compression is enabled. This
method removes such
Review Comment:
thanks for the pointer. Was this causing test failures? I don't see etags
with --gzip when running with the changes from
https://github.com/apache/iceberg/pull/10837, so I wonder whether you ran into
issues here? I'm wondering whether that started to happen after switching to
the new Compression API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
