bryanck commented on code in PR #15234:
URL: https://github.com/apache/iceberg/pull/15234#discussion_r2805222791
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -86,7 +86,6 @@ public class IcebergSinkConfig extends AbstractConfig {
private static final String COMMIT_TIMEOUT_MS_PROP =
"iceberg.control.commit.timeout-ms";
private static final int COMMIT_TIMEOUT_MS_DEFAULT = 30_000;
private static final String COMMIT_THREADS_PROP =
"iceberg.control.commit.threads";
- private static final String CONNECT_GROUP_ID_PROP =
"iceberg.connect.group-id";
Review Comment:
This is a breaking change, I feel we should keep the property the same.
Alternatively, keep both and mark this as deprecated for a few release cycles
before removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
