manuzhang commented on code in PR #15118:
URL: https://github.com/apache/iceberg/pull/15118#discussion_r2809472784
##########
site/dev/common.sh:
##########
@@ -48,7 +48,8 @@ install_deps () {
echo " --> install deps"
# Use pip from venv to install or upgrade dependencies from the
'requirements.txt' file quietly
- "${VENV_DIR}/bin/pip3" -q install -r requirements.txt --upgrade
+ local PIP="${PIP:-${VENV_DIR}/bin/pip3}"
+ ${PIP} -q install -r requirements.txt --upgrade
Review Comment:
In my `venv` set up by `uv`, there's no `pip` or `pip3` command. `uv pip` is
needed here. However, I don't think we should change all commands to `uv`,
which requires everyone to use `uv` locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
