rdblue commented on pull request #1792: URL: https://github.com/apache/iceberg/pull/1792#issuecomment-731455078
> It does not provide several common methods, such as toString(), equals, hashCode etc. It's useful for testing. So I make it extend the AbstractSet. StructLikeSet does implement [equals](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/util/StructLikeSet.java#L155) and [hashCode](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/util/StructLikeSet.java#L177). And `toString` isn't implemented by `AbstractSet` so I don't see much value in adding the superclass. Is there anything that we gain from this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
