kevinjqliu commented on code in PR #15334:
URL: https://github.com/apache/iceberg/pull/15334#discussion_r2812754263
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -75,13 +81,6 @@ protected BaseFileWriterFactory(
this.positionDeleteRowSchema = null;
}
- /**
- * @deprecated This constructor is deprecated as of version 1.11.0 and will
be removed in 1.12.0.
- * Position deletes that include row data are no longer supported. Use
{@link
Review Comment:
> Position deletes that include row data are no longer supported
is this still true? i noticed its missing in the new deprecation message
##########
data/src/main/java/org/apache/iceberg/data/GenericFileWriterFactory.java:
##########
@@ -107,62 +130,163 @@ public class GenericFileWriterFactory extends
BaseFileWriterFactory<Record> {
super(
table,
dataFileFormat,
+ Record.class,
dataSchema,
dataSortOrder,
deleteFileFormat,
equalityFieldIds,
equalityDeleteRowSchema,
equalityDeleteSortOrder,
- positionDeleteRowSchema);
+ ImmutableMap.of(),
+ dataSchema,
+ equalityDeleteRowSchema);
+ this.table = table;
+ this.format = dataFileFormat;
+ this.positionDeleteRowSchema = positionDeleteRowSchema;
}
static Builder builderFor(Table table) {
return new Builder(table);
}
- @Override
+ /**
+ * @deprecated Since 1.10.0, will be removed in 1.11.0. It won't be called
starting 1.10.0 as the
Review Comment:
trying to wrap my head around the timing aspect for this comment...
1.10.x is already released. This PR will be included in 1.11.x (hopefully).
Is it ok to say that its been deprecated since 1.10.0 since it has not been
marked as deprecated in 1.10.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
