ella-chao opened a new issue, #731: URL: https://github.com/apache/iceberg-go/issues/731
### Apache Iceberg version main (development) ### Please describe the bug 🐞 There are two issues with this function: 1. The carry from the increment [here](https://github.com/apache/iceberg-go/blob/cfab819d919f3497a8f1f7e0062715cb407234fc/literals.go#L1310) is lost, so given the input -256 for example [0xFE, 0x00] is returned instead of [0xFF, 00]. 2. The min bytes calculation [here](https://github.com/apache/iceberg-go/blob/cfab819d919f3497a8f1f7e0062715cb407234fc/literals.go#L1302) is wrong for -2^7, -2^15, etc. These fit in one fewer byte than what `minBytes` is reporting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
