pvary commented on code in PR #15329:
URL: https://github.com/apache/iceberg/pull/15329#discussion_r2814376407
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java:
##########
@@ -319,11 +321,32 @@ public void testTableWithTargetFileSize() throws
Exception {
public void testPromotedFlinkDataType() throws Exception {
Schema iSchema =
new Schema(
+ Types.NestedField.required(
Review Comment:
I remember that in one of the versions of the code I needed to test embedded
objects. It's kind of late here, but it was somewhat related to the change with
the `FlinkSchemaVisitor`, but I can't find the usage anymore. So it might not
be needed in the end.
Let me revert the changes and see if any tests fail. That will help me in
the morning to remember the history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
