bodduv commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2816480396
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -80,15 +103,20 @@ private class MetricsEvalVisitor extends
BoundExpressionVisitor<Boolean> {
private Map<Integer, Statistics<?>> stats = null;
private Map<Integer, Long> valueCounts = null;
private Map<Integer, Function<Object, Object>> conversions = null;
+ // Flag to use signed UUID comparator for backward compatibility.
+ // This is needed for the IN predicate because the comparator information
is lost
+ // when binding converts literals to a Set<T> of raw values.
+ private boolean useSignedUuidComparator = false;
- private boolean eval(MessageType fileSchema, BlockMetaData rowGroup) {
+ private boolean eval(MessageType fileSchema, BlockMetaData rowGroup,
boolean signedUuidMode) {
Review Comment:
I was impartial to this, but after your comment, I decided to have
consistency among the three:
- `ParquetMetricsRowGroupFilter`
- `InclusiveMetricsEvaluator`
- `ManifestEvalutor`
Making the enclosed class static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
