jackye1995 commented on pull request #1786: URL: https://github.com/apache/iceberg/pull/1786#issuecomment-731642851
> @jackye1995 I just pushed #1767 in order to get the progressive upload in (it was already a pretty large PR). We can use this issue to revisit how to handle the encryption. > > I'd prefer not to use the reflection approach (not necessarily due to the performance impact since the number of S3 calls is relatively small), but rather that doesn't allow for compile time checks and will be harder to reason about and maintain. > > I'm open to either the function or base approaches, but maybe once this is rebased and we add the multipart versions of this it will be more clear which approach makes the most sense. Sure, let me rebase it and see ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
