dttung2905 commented on code in PR #728:
URL: https://github.com/apache/iceberg-go/pull/728#discussion_r2818527221
##########
table/snapshot_producers.go:
##########
@@ -703,17 +703,34 @@ func (sp *snapshotProducer) commit() (_ []Update, _
[]Requirement, err error) {
parentSnapshot = &sp.parentSnapshotID
}
+ firstRowID := int64(0)
+ var addedRows int64
+
out, err := sp.io.Create(manifestListFilePath)
if err != nil {
return nil, nil, err
}
defer internal.CheckedClose(out, &err)
- // TODO: Implement v3 here
- err = iceberg.WriteManifestList(sp.txn.meta.formatVersion, out,
- sp.snapshotID, parentSnapshot, &nextSequence, 0, newManifests)
- if err != nil {
- return nil, nil, err
+ if sp.txn.meta.formatVersion == 3 {
Review Comment:
Do you think we should result to use the single API `WriteManifestList` for
all 3 version instead of branching out like this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
