singhpk234 commented on code in PR #14867:
URL: https://github.com/apache/iceberg/pull/14867#discussion_r2820263765
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTScanPlanning.java:
##########
@@ -805,6 +834,71 @@ private static class CatalogWithAdapter {
}
}
+ /**
+ * Helper method to create a catalog with custom scan planning mode
configuration for testing
+ * client-server mode validation.
+ *
+ * @param clientMode The scan planning mode the client requests (null for
default)
+ * @param serverMode The scan planning mode the server returns (null for not
set)
+ * @return CatalogWithAdapter for testing
+ */
+ private CatalogWithAdapter catalogWithScanPlanningModes(String clientMode,
String serverMode) {
+ RESTCatalogAdapter adapter =
Review Comment:
tried some code reuse they are not exactly same but they have some lines
common for sure !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
