jwtryg opened a new issue, #738: URL: https://github.com/apache/iceberg-go/issues/738
### Apache Iceberg version None ### Please describe the bug 🐞 Currently, SAS tokens are requested from the properties map using the storage account name, which is extracted from the adls hostname, see: https://github.com/apache/iceberg-go/blob/0d6c10ead0cfe49e3cbf01d087509b0dae7205da/io/azure.go#L157 However, looking at the [original java implementation](https://github.com/apache/iceberg/blob/d06e6c22fecf00be81f2eb399f090fae320560a4/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L171), although the parameter is called account, we can see that the function is actually called with the full hostname: https://github.com/apache/iceberg/blob/d06e6c22fecf00be81f2eb399f090fae320560a4/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java#L156. Further, looking at an example from Azure DBx, we see the SAS token is being returned with the full hostname suffixed, not only the account name: https://learn.microsoft.com/en-us/azure/databricks/external-access/iceberg#rest-api-curl-example. I will gladly contribute a fix - in that case, I just want to know whether we want to keep the current behaviour also, and try both account name and hostname? Or change the behaviour to always use the hostname. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
