jackye1995 commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r528433500
##########
File path: api/src/main/java/org/apache/iceberg/ContentFile.java
##########
@@ -132,7 +137,8 @@
* Copies this file without file stats. Manifest readers can reuse file
instances; use
* this method to copy data without stats when collecting files.
*
- * @return a copy of this data file, without lower bounds, upper bounds,
value counts, or null value counts
+ * @return a copy of this data file, without lower bounds, upper bounds,
value counts,
+ * null value counts, or nan value counts
Review comment:
nit: newline should start at the same place as last line
##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -116,8 +117,8 @@ public PartitionData copy() {
}
BaseFile(int specId, FileContent content, String filePath, FileFormat format,
- PartitionData partition, long fileSizeInBytes, long recordCount,
- Map<Integer, Long> columnSizes, Map<Integer, Long> valueCounts,
Map<Integer, Long> nullValueCounts,
+ PartitionData partition, long fileSizeInBytes, long recordCount,
Map<Integer, Long> columnSizes,
Review comment:
nit: can we keep the existing lines the same?
##########
File path: spark/src/test/java/org/apache/iceberg/TestDataFileSerialization.java
##########
@@ -68,14 +69,16 @@
private static final Map<Integer, Long> VALUE_COUNTS = Maps.newHashMap();
private static final Map<Integer, Long> NULL_VALUE_COUNTS =
Maps.newHashMap();
+ private static final Map<Integer, Long> NAN_VALUE_COUNTS = Maps.newHashMap();
private static final Map<Integer, ByteBuffer> LOWER_BOUNDS =
Maps.newHashMap();
private static final Map<Integer, ByteBuffer> UPPER_BOUNDS =
Maps.newHashMap();
static {
VALUE_COUNTS.put(1, 5L);
VALUE_COUNTS.put(2, 3L);
+ VALUE_COUNTS.put(4, 2L);
NULL_VALUE_COUNTS.put(1, 0L);
- NULL_VALUE_COUNTS.put(2, 2L);
Review comment:
why are we modifying this line instead of adding a new line?
##########
File path: core/src/main/java/org/apache/iceberg/V1Metadata.java
##########
@@ -356,7 +356,7 @@ public Object get(int pos) {
@Override
public void put(int i, Object v) {
- throw new UnsupportedOperationException("Cannot read into
IndexedDataFile");
+ throw new UnsupportedOperationException("Cannot write into
IndexedDataFile");
Review comment:
what is this change for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
