zeroshade commented on code in PR #732:
URL: https://github.com/apache/iceberg-go/pull/732#discussion_r2823520865
##########
.github/workflows/go-integration.yml:
##########
@@ -66,18 +60,17 @@ jobs:
AWS_S3_ENDPOINT: "${{ env.AWS_S3_ENDPOINT }}"
AWS_REGION: "us-east-1"
run: |
- go test -tags integration -v -run="^TestScanner" ./table
- go test -tags integration -v ./io
- go test -tags integration -v -run="^TestRestIntegration$"
./catalog/rest
- go test -tags=integration -v ./catalog/hive/...
+ make integration-io
+ make integration-rest
+ make integration-spark
+ make integration-hive
- name: Run spark integration tests
env:
AWS_S3_ENDPOINT: "${{ env.AWS_S3_ENDPOINT }}"
AWS_REGION: "us-east-1"
SPARK_CONTAINER_ID: "${{ env.SPARK_CONTAINER_ID }}"
DOCKER_API_VER: "${{ env.DOCKER_API_VER }}"
- run: |
- go test -tags integration -v -run="^TestSparkIntegration" ./table
+ run: make integration-spark
Review Comment:
Do we still need this as a separate step anymore? We can shift the env vars
for SPARK_CONTAINER_ID and DOCKER_API_VER to the step above and just call `make
integration-test`
##########
Makefile:
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the "License");
+# you may not use it except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# golangci-lint version (keep in sync with CI and README)
+GOLANGCI_LINT_VERSION := v2.8.0
+
+.PHONY: test lint lint-install integration-setup integration-test
integration-scanner integration-io integration-rest integration-spark
+
+test:
+ go test -v ./...
+
+lint:
+ golangci-lint run --timeout=10m
+
+lint-install:
+ go install
github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)
+
+integration-setup:
+ docker compose -f internal/recipe/docker-compose.yml up -d
+ sleep 10
+ docker compose -f internal/recipe/docker-compose.yml exec -T
spark-iceberg ipython ./provision.py
+ sleep 10
+
+integration-test: integration-scanner integration-io integration-rest
integration-spark
Review Comment:
shouldn't `integration-hive` be part of this too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
