rdblue commented on code in PR #15111:
URL: https://github.com/apache/iceberg/pull/15111#discussion_r2823608842
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -53,6 +52,8 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
private static final Logger LOG =
LoggerFactory.getLogger(HadoopFileIO.class);
private static final String DELETE_FILE_PARALLELISM =
"iceberg.hadoop.delete-file-parallelism";
private static final String DELETE_FILE_POOL_NAME =
"iceberg-hadoopfileio-delete";
+ public static final String DELETE_TRASH_SCHEMAS =
"iceberg.hadoop.delete-trash-schemas";
+ private static final String[] DEFAULT_TRASH_SCHEMAS = {"hdfs", "viewfs"};
Review Comment:
It looks like this is referring to the [URI
"scheme"](https://datatracker.ietf.org/doc/html/rfc3986#section-3.1) as
"schema". Most places in Iceberg use the RFC terminology, so this should as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
