huaxingao commented on code in PR #15340:
URL: https://github.com/apache/iceberg/pull/15340#discussion_r2823750894
##########
docker/iceberg-flink-quickstart/docker-compose.yml:
##########
@@ -130,12 +130,17 @@ services:
condition: service_healthy
networks:
iceberg_net:
+ healthcheck:
+ test: ["CMD", "mc", "ls", "minio/warehouse"]
+ interval: 5s
+ timeout: 5s
+ retries: 5
entrypoint: |
/bin/sh -c "
- until (/usr/bin/mc alias set minio http://minio:9000 admin password) do
echo '...waiting...' && sleep 1; done;
- /usr/bin/mc rm -r --force minio/warehouse;
- /usr/bin/mc mb minio/warehouse;
- /usr/bin/mc policy set public minio/warehouse;
+ /usr/bin/mc alias set minio http://minio:9000 admin password;
+ /usr/bin/mc mb --ignore-existing minio/warehouse;
+ /usr/bin/mc anonymous set public minio/warehouse;
+ tail -f /dev/null
Review Comment:
question: do we need `tail -f /dev/null` in `create-bucket`? Since bucket
creation is now “safe to rerun” (`mc mb --ignore-existing`), could
`create-bucket` just do the setup and then exit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
