yyanyy commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r528924364
##########
File path: spark/src/test/java/org/apache/iceberg/TestDataFileSerialization.java
##########
@@ -68,14 +69,16 @@
private static final Map<Integer, Long> VALUE_COUNTS = Maps.newHashMap();
private static final Map<Integer, Long> NULL_VALUE_COUNTS =
Maps.newHashMap();
+ private static final Map<Integer, Long> NAN_VALUE_COUNTS = Maps.newHashMap();
private static final Map<Integer, ByteBuffer> LOWER_BOUNDS =
Maps.newHashMap();
private static final Map<Integer, ByteBuffer> UPPER_BOUNDS =
Maps.newHashMap();
static {
VALUE_COUNTS.put(1, 5L);
VALUE_COUNTS.put(2, 3L);
+ VALUE_COUNTS.put(4, 2L);
NULL_VALUE_COUNTS.put(1, 0L);
- NULL_VALUE_COUNTS.put(2, 2L);
Review comment:
Oh good catch, I guess I thought I duplicated the line myself but seems
like it was from the original code; I'll add it back
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
