mxm commented on code in PR #15381:
URL: https://github.com/apache/iceberg/pull/15381#discussion_r2833179480
##########
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##########
@@ -99,6 +101,18 @@ default RewriteTablePath createFileList(boolean
createFileList) {
return this;
}
+ /**
+ * Passes an alternative executor service that will be used for version file
and manifest list
+ * rewriting. If this method is not called, these operations will be
performed sequentially.
+ *
+ * @param executorService an executor service to parallelize metadata
rewriting
+ * @return this for method chaining
+ */
+ default RewriteTablePath executeWith(ExecutorService executorService) {
+ throw new UnsupportedOperationException(
+ "This implementation does not support providing an ExecutorService.");
+ }
Review Comment:
I saw that other PRs just did a `return this` here, but it feels wrong to
ignore the provided ExecutorService entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
