Fokko commented on code in PR #2996: URL: https://github.com/apache/iceberg-python/pull/2996#discussion_r2834956495
########## Makefile: ########## @@ -149,29 +156,23 @@ coverage-report: ## Combine and report coverage ##@ Documentation -docs-install: ## Install docs dependencies (included in default groups) - uv sync $(PYTHON_ARG) --group docs - docs-serve: ## Serve local docs preview (hot reload) - uv run $(PYTHON_ARG) mkdocs serve -f mkdocs/mkdocs.yml --livereload + uv run $(PYTHON_ARG) --group docs mkdocs serve -f mkdocs/mkdocs.yml --livereload docs-build: ## Build the static documentation site - uv run $(PYTHON_ARG) mkdocs build -f mkdocs/mkdocs.yml --strict + uv run $(PYTHON_ARG) --group docs mkdocs build -f mkdocs/mkdocs.yml --strict # ======================== # Experimentation # ======================== ##@ Experimentation -notebook-install: ## Install notebook dependencies - uv sync $(PYTHON_ARG) --all-extras --group notebook - -notebook: notebook-install ## Launch notebook for experimentation - uv run jupyter lab --notebook-dir=notebooks +notebook: ## Launch notebook for experimentation + uv run $(PYTHON_ARG) --all-extras --group notebook jupyter lab --notebook-dir=notebooks -notebook-infra: notebook-install test-integration-setup ## Launch notebook with integration test infra (Spark, Iceberg Rest Catalog, object storage, etc.) - uv run jupyter lab --notebook-dir=notebooks +notebook-infra: test-integration-setup ## Launch notebook with integration test infra (Spark, Iceberg Rest Catalog, object storage, etc.) + uv run $(PYTHON_ARG) --all-extras --group notebook jupyter lab --notebook-dir=notebooks Review Comment: Nice catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
