alexandre-normand commented on code in PR #721:
URL: https://github.com/apache/iceberg-go/pull/721#discussion_r2835291759
##########
table/arrow_scanner.go:
##########
@@ -189,6 +192,54 @@ func processPositionalDeletes(ctx context.Context, deletes
set[int64]) recProces
}
}
+// enrichRecordsWithPosDeleteFields enriches a RecordBatch with the columns
declared in the PositionalDeleteArrowSchema
+// so that during the pipeline filtering stages that sheds filtered out
records, we still have a way to
+// preserve the original position of those records.
+func enrichRecordsWithPosDeleteFields(ctx context.Context, filePath
iceberg.DataFile) recProcessFn {
Review Comment:
Added those tests in aae5b2f81471cea2fef873e0a2c20c52800512cb except for the
missing required fields since that would mean injecting a different
`PositionalDeleteArrowSchema` which is not really a good idea since that's a
fixed thing.
While I was looking at that one, I decided to make the error on missing
required field a panic since that would be a bug/regression introduced by
someone changing the constant schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
