yyanyy commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r529005698
##########
File path: api/src/main/java/org/apache/iceberg/NaNOnlyFieldMetrics.java
##########
@@ -17,51 +17,50 @@
* under the License.
*/
-package org.apache.iceberg.parquet;
+package org.apache.iceberg;
import java.nio.ByteBuffer;
-import org.apache.iceberg.FieldMetrics;
/**
- * Iceberg internally tracked field level metrics, used by Parquet writer only.
+ * Iceberg internally tracked field level metrics, used by Parquet and ORC
writers only.
* <p>
- * Parquet keeps track of most metrics in its footer, and only NaN counter is
actually tracked by writers.
- * This wrapper ensures that metrics not being updated by Parquet writers will
not be incorrectly used, by throwing
+ * Parquet/ORC keeps track of most metrics in file statistics, and only NaN
counter is actually tracked by writers.
+ * This wrapper ensures that metrics not being updated by those writers will
not be incorrectly used, by throwing
* exceptions when they are accessed.
*/
-public class ParquetFieldMetrics extends FieldMetrics {
Review comment:
Yeah that's also an alternative approach, I wasn't sure if I want to
directly duplicate the code in `ParquetFieldMetrics` to create a ORC version
though since I don't think parquet/ORC libraries will support NaN natively
soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
