rcjverhoef commented on PR #15304: URL: https://github.com/apache/iceberg/pull/15304#issuecomment-3940631229
> @rcjverhoef do you want to add the properties filter + `create()` - noarg - support in your PR to align on credential provider pattern? Or do we align credential provider one on your PR which is passing all properties? 🤔 @rmannibucau your PR takes a more generic approach, placing the config in AwsClientProperties aligned with the credential provider pattern. Mine is scoped to S3FileIO specifically, configuring the metrics publisher per S3 client instance. What I reversed engineered so far, is that every S3FileIO gets its own AWS client. This is particular useful for vended credentials and remote signing, but there is probably more. I am hooking the metrics publisher in at that level. The more I think about it, I am wondering if your approach makes more sense. I don't really know under which circumstances you'd want that have different metrics publishers for each client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
