jackye1995 commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r529018312
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/StructInternalRow.java
##########
@@ -115,12 +120,30 @@ public short getShort(int ordinal) {
@Override
public int getInt(int ordinal) {
- return struct.get(ordinal, Integer.class);
+ Object integer = struct.get(ordinal, Object.class);
Review comment:
If so, should we publish a separated PR for this? My biggest concern is
that people might have different opinions about the way to handle these data
types. When embedded as a part of a big PR, it gets less attention for people
who are interested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
