deniskuzZ commented on code in PR #15384:
URL: https://github.com/apache/iceberg/pull/15384#discussion_r2841313453


##########
api/src/test/java/org/apache/iceberg/expressions/TestPathUtil.java:
##########
@@ -123,4 +123,42 @@ public void testNormalizedFieldLists(List<String> fields, 
String normalizedPath)
   public void testPathEscaping(String name, String escaped) {
     assertThat(PathUtil.rfc9535escape(name)).isEqualTo(escaped);
   }
+
+  private static final String[][] TO_DOT_NOTATION_CASES =
+      new String[][] {
+        new String[] {"$", "$"},
+        new String[] {"$['a']", "$.a"},
+        new String[] {"$['a']['b']", "$.a.b"},

Review Comment:
   does it cover structs? shredded variant inside struct or shredded struct 
field in variant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to