kevinjqliu commented on code in PR #750:
URL: https://github.com/apache/iceberg-go/pull/750#discussion_r2843390502


##########
.github/workflows/go-release-docs.yml:
##########
@@ -31,6 +31,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
   cancel-in-progress: true
 
+permissions:
+  contents: read

Review Comment:
   write permission is scope to the job
   
https://github.com/apache/iceberg-go/pull/750/files#diff-3c80696699b39a127cedd4291d850e4eab62f869e9c7ae76306a50d5a664edd5R38-R41
   
   i guess this change is no-op. its just good habit to default the entire 
workflow to read in case of future job additions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to