yyanyy commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r529063378
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -148,6 +150,39 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
return ROWS_MIGHT_MATCH;
}
+ @Override
+ public <T> Boolean isNaN(BoundReference<T> ref) {
+ int id = ref.fieldId();
+
+ Boolean hasNonDictPage = isFallback.get(id);
+ if (hasNonDictPage == null || hasNonDictPage) {
+ return ROWS_MIGHT_MATCH;
+ }
+
+ Set<T> dictionary = dict(id, comparatorForNaNPredicate(ref));
+ return dictionary.stream().anyMatch(NaNUtil::isNaN) ? ROWS_MIGHT_MATCH :
ROWS_CANNOT_MATCH;
+ }
+
+ @Override
+ public <T> Boolean notNaN(BoundReference<T> ref) {
+ int id = ref.fieldId();
+
+ Boolean hasNonDictPage = isFallback.get(id);
+ if (hasNonDictPage == null || hasNonDictPage) {
+ return ROWS_MIGHT_MATCH;
+ }
+
+ Set<T> dictionary = dict(id, comparatorForNaNPredicate(ref));
+ return dictionary.stream().allMatch(NaNUtil::isNaN) ? ROWS_CANNOT_MATCH
: ROWS_MIGHT_MATCH;
+ }
+
+ private <T> Comparator<T> comparatorForNaNPredicate(BoundReference<T> ref)
{
Review comment:
Thanks for the info! I'll update this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
