blackmwk commented on code in PR #1997:
URL: https://github.com/apache/iceberg-rust/pull/1997#discussion_r2843872564
##########
bindings/python/tests/test_datafusion_table_provider.py:
##########
@@ -25,10 +25,13 @@
import pyarrow as pa
from pathlib import Path
import datafusion
+from packaging.version import Version
-assert (
- datafusion.__version__ >= "45"
-) # iceberg table provider only works for datafusion >= 45
+if Version(datafusion.__version__) < Version("52.0.0"):
Review Comment:
Not related to this pr, but is it possible to extract the version from
workspace `Cargo.toml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
