pvary commented on PR #15422: URL: https://github.com/apache/iceberg/pull/15422#issuecomment-3950498813
> > I think not using that in certain cases is actually acceptable or even preferable. If the method body is short, you may want to skip the extra empty lines around if blocks. > > Fair enough, currently it's all up to the reviewer though to determine this so it's not great. I'm really tried of pointing out the new line stuff for every review. Could we just make this work reasonably well, and do the refactor before a release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
