rdblue commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529089416
##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -59,10 +60,13 @@
"Splittable offsets");
Types.NestedField EQUALITY_IDS = optional(135, "equality_ids",
ListType.ofRequired(136, IntegerType.get()),
"Equality comparison field IDs");
+ Types.NestedField NAN_VALUE_COUNTS = optional(137, "nan_value_counts",
MapType.ofRequired(138, 139,
+ IntegerType.get(), LongType.get()), "Map of column id to number of NaN
values in the column");
Review comment:
Could you move this up by `NULL_VALUE_COUNTS`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
