rdblue commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529089859
##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -96,4 +101,9 @@ default FileContent content() {
default List<Integer> equalityFieldIds() {
return null;
}
+
+ @Override
+ default Map<Integer, Long> nanValueCounts() {
+ return null;
+ }
Review comment:
I think all of the implementations will provide this method, so there
should be no need for the default, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
