dramaticlly commented on code in PR #15426:
URL: https://github.com/apache/iceberg/pull/15426#discussion_r2849204623
##########
core/src/test/java/org/apache/iceberg/TestFindFiles.java:
##########
@@ -209,15 +210,20 @@ public void testNoSnapshot() {
@TestTemplate
public void testPlanWith() {
- table
- .newAppend()
- .appendFile(FILE_A)
- .appendFile(FILE_B)
- .appendFile(FILE_C)
- .appendFile(FILE_D)
- .commit();
-
- ExecutorService executorService = Executors.newFixedThreadPool(2);
+ table.newAppend().appendFile(FILE_A).appendFile(FILE_B).commit();
+ table.newAppend().appendFile(FILE_C).appendFile(FILE_D).commit();
+ assertThat(table.currentSnapshot().dataManifests(table.io())).hasSize(2);
+
+ AtomicInteger planThreadsIndex = new AtomicInteger(0);
+ ExecutorService executorService =
+ Executors.newFixedThreadPool(
Review Comment:
I think we still build against java17, so we can migrate this later once we
move to jdk21 as minimal support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
