rdblue commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529090853
##########
File path: core/src/main/java/org/apache/iceberg/V2Metadata.java
##########
@@ -254,7 +254,8 @@ static Schema wrapFileSchema(Types.StructType fileSchema) {
DataFile.UPPER_BOUNDS,
DataFile.KEY_METADATA,
DataFile.SPLIT_OFFSETS,
- DataFile.EQUALITY_IDS
+ DataFile.EQUALITY_IDS,
+ DataFile.NAN_VALUE_COUNTS
Review comment:
Similar to above, I think we should add NaN value counts just below null
value counts. This will affect the ordinals in `get` so you'll have to update
them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
